Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-keepalived: add missing variable declarations #7540

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

dannil
Copy link
Contributor

@dannil dannil commented Jan 8, 2025

  • This PR is not from my main or master branch πŸ’©, but a separate branch βœ…
  • Each commit has a valid βœ’οΈ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid πŸ“ <package name>: title first line subject for packages
  • Incremented πŸ†™ any PKG_VERSION in the Makefile N/A
  • Tested on: (x86/64, 24.10.0-rc4, Firefox) βœ…
  • ( Preferred ) Mention: @ the original code author for feedback @jempatel
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: e.g. luci-app-keepalived: scripts brokenΒ #7536
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: (describe the changes proposed in this PR)

Before:
Screenshot_30

After:
Screenshot_29

@dannil dannil mentioned this pull request Jan 8, 2025
1 task
@dannil dannil marked this pull request as draft January 8, 2025 19:19
Signed-off-by: Daniel Nilsson <dannil+github@protonmail.com>
@dannil dannil force-pushed the keepalived-declare-var branch from 0946804 to d7a4b1c Compare January 8, 2025 19:20
@dannil dannil changed the title luci-app-keepalived: add missing variable declaration luci-app-keepalived: add missing variable declarations Jan 8, 2025
@dannil dannil marked this pull request as ready for review January 8, 2025 19:20
@feckert feckert merged commit a75c904 into openwrt:master Jan 9, 2025
5 checks passed
@feckert
Copy link
Member

feckert commented Jan 9, 2025

Thanks merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants