Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luci-mod-dashboard: make the DHCP Devices and Wireless proper tables with headers. #7550

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

luci-mod-dashboard: make the DHCP Devices and Wireless proper tables with headers. #7550

wants to merge 1 commit into from
+12 −25

Conversation

adelton
Copy link
Contributor

@adelton adelton commented Jan 9, 2025 •
edited
Loading

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile
  • Tested on: local x86_64 VM with OpenWrt 23.05.5 (r24106-10cc5fcd00)
  • ( Preferred ) Mention: @ZoZhang
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: e.g. openwrt/luci#issue-number
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: Related to luci-mod-dashboard: wrapping of long hostnames #7476: make the DHCP Devices and Wireless proper tables with headers, remove <hr/>s that can be done with CSS, create baseline for proper CSS styling.

@systemcrash
Copy link
Contributor

OK. Please squash your commits.

@adelton
luci-mod-dashboard: make the DHCP Devices and Wireless proper tables …
34b9929 
…with headers.

Also, the Lan and WiFi tables are half-width, we should not use the table-titles which has @media rules about 992px.

Signed-off-by: Jan Pazdziora <jan.pazdziora@code.adelton.com>
@adelton
Copy link
Contributor Author

adelton commented Jan 10, 2025

Squashed, rebased on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systemcrash systemcrash systemcrash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adelton @systemcrash