Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store substitutions in Parameters #220

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

SoongNoonien
Copy link
Member

No description provided.

@SoongNoonien SoongNoonien force-pushed the substitutions branch 3 times, most recently from d99d957 to 3943415 Compare October 17, 2024 15:01
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (b58bb35) to head (d99602a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   95.99%   96.19%   +0.19%     
==========================================
  Files          13       12       -1     
  Lines         849      840       -9     
==========================================
- Hits          815      808       -7     
+ Misses         34       32       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SoongNoonien SoongNoonien marked this pull request as ready for review October 17, 2024 15:41
@fingolfin fingolfin merged commit 133a57e into oscar-system:master Oct 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants