Skip to content

Commit

Permalink
Classic-BC support
Browse files Browse the repository at this point in the history
  • Loading branch information
parnic committed May 9, 2021
1 parent 481793c commit 1798e82
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 9 deletions.
11 changes: 8 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,16 @@ jobs:

# once cloned, we just run the GitHub Action for the packager project
- name: Package and release
uses: BigWigsMods/packager@master
uses: BigWigsMods/packager@c91d8d4e55bedd96dbb6cb4a564d853d2ed2ce1c

# another example where we supply additional arguments, this example is specifically to release
# for the Classic version of the game
- name: Package and release for Classic
uses: BigWigsMods/packager@master
uses: BigWigsMods/packager@c91d8d4e55bedd96dbb6cb4a564d853d2ed2ce1c
with:
args: -g 1.13.6 -w 0
args: -g classic -w 0

- name: Package and release for TBC
uses: BigWigsMods/packager@c91d8d4e55bedd96dbb6cb4a564d853d2ed2ce1c
with:
args: -g bc -w 0
3 changes: 2 additions & 1 deletion Breakables.lua
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ end

local WowVer = select(4, GetBuildInfo())
local IsClassic = WOW_PROJECT_ID and WOW_PROJECT_ID == WOW_PROJECT_CLASSIC
local IsClassicBC = WOW_PROJECT_ID and WOW_PROJECT_ID == WOW_PROJECT_BURNING_CRUSADE_CLASSIC

local MillingId = 51005
local MillingItemSubType = babbleInv["Herb"]
Expand Down Expand Up @@ -1382,7 +1383,7 @@ function Breakables:BreakableIsDisenchantable(itemType, itemLevel, itemRarity, i
for i=1,#DisenchantTypes do
if DisenchantTypes[i] == itemType or IsArtifactRelicItem(itemLink) then
-- temp hack for bfa until disenchant item level scales are identified. and for classic until finding the profession level api
if WowVer >= 80000 or IsClassic then
if WowVer >= 80000 or IsClassic or IsClassicBC then
return true
end

Expand Down
8 changes: 3 additions & 5 deletions Breakables.toc
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
#@retail@
## Interface: 90005
#@end-retail@
#@non-retail@
# ## Interface: 11306
#@end-non-retail@
## Interface-Retail: 90005
## Interface-Classic: 11306
## Interface-BC: 20501
## Author: Parnic
## Name: Breakables
## Title: Breakables |cff7fff7f-Ace3-|r
Expand Down
3 changes: 3 additions & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
vNext:
- Classic-BC support

v1.7.4:
- Fix an issue when IsArtifactRelicItem is not defined

Expand Down

0 comments on commit 1798e82

Please sign in to comment.