Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag until fully visible #97

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Drag until fully visible #97

wants to merge 22 commits into from
+1,103 −627

Conversation

danielmolnar
Copy link
Collaborator

@danielmolnar danielmolnar commented Jan 13, 2025 •
edited
Loading

This PR adjusts/enhances

dragUntilVisible

  • Ensure dragTarget is fully visible after a successful drag (not just partially), by using Size and Offset of the Scrollable's RenderObject to determine whether dragTarget is visible and automatically moving dragTarget to dragStart's previous location

  • Make moveStep optional

  • Added tests (horizontal drag tests, assertion tests)

Timeline

  • Added DragError-Event

@danielmolnar danielmolnar marked this pull request as draft January 13, 2025 23:42
@danielmolnar danielmolnar marked this pull request as ready for review January 14, 2025 00:52
@danielmolnar danielmolnar requested a review from passsy January 14, 2025 00:53
@danielmolnar danielmolnar marked this pull request as draft January 14, 2025 11:53
@danielmolnar danielmolnar marked this pull request as ready for review January 14, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@passsy passsy Awaiting requested review from passsy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmolnar @passsy