Removed abstract exceptions & fixed inheritance

src/Exception/LzmaCouldNotCompressData.php

@@ -4,6 +4,11 @@
 
 namespace PetrKnap\XzUtils\Exception;
 
-final class LzmaCouldNotCompressData extends CouldNotCompressData implements LzmaException
+use PetrKnap\Shorts\Exception\CouldNotProcessData;
+
+/**
+ * @extends CouldNotProcessData<string>
+ */
+final class LzmaCouldNotCompressData extends CouldNotProcessData implements LzmaException
 {
 }

src/Exception/LzmaCouldNotDecompressData.php

@@ -4,6 +4,11 @@
 
 namespace PetrKnap\XzUtils\Exception;
 
-final class LzmaCouldNotDecompressData extends CouldNotDecompressData implements XzException
+use PetrKnap\Shorts\Exception\CouldNotProcessData;
+
+/**
+ * @extends CouldNotProcessData<string>
+ */
+final class LzmaCouldNotDecompressData extends CouldNotProcessData implements LzmaException
 {
 }

src/Exception/XzCouldNotCompressData.php

@@ -4,6 +4,11 @@
 
 namespace PetrKnap\XzUtils\Exception;
 
-final class XzCouldNotCompressData extends CouldNotCompressData implements XzException
+use PetrKnap\Shorts\Exception\CouldNotProcessData;
+
+/**
+ * @extends CouldNotProcessData<string>
+ */
+final class XzCouldNotCompressData extends CouldNotProcessData implements XzException
 {
 }

src/Exception/XzCouldNotDecompressData.php

@@ -4,6 +4,11 @@
 
 namespace PetrKnap\XzUtils\Exception;
 
-final class XzCouldNotDecompressData extends CouldNotDecompressData implements XzException
+use PetrKnap\Shorts\Exception\CouldNotProcessData;
+
+/**
+ * @extends CouldNotProcessData<string>
+ */
+final class XzCouldNotDecompressData extends CouldNotProcessData implements XzException
 {
 }

src/Lzma.php

@@ -14,7 +14,10 @@ protected static function compressException(): string
         return Exception\LzmaCouldNotCompressData::class;
     }
 
-    protected static function decompressException(): string
+    /**
+     * @internal public for testing purposes only
+     */
+    public static function decompressException(): string
     {
         return Exception\LzmaCouldNotDecompressData::class;
     }

src/Xz.php

@@ -14,7 +14,10 @@ protected static function compressException(): string
         return Exception\XzCouldNotCompressData::class;
     }
 
-    protected static function decompressException(): string
+    /**
+     * @internal public for testing purposes only
+     */
+    public static function decompressException(): string
     {
         return Exception\XzCouldNotDecompressData::class;
     }

src/XzUtils.php

@@ -5,19 +5,20 @@
 namespace PetrKnap\XzUtils;
 
 use PetrKnap\ExternalFilter\Exception\FilterException;
+use PetrKnap\Shorts\Exception\CouldNotProcessData;
 
 /**
  * @internal shared logic
  *
- * @template TCompressException of Exception\CouldNotCompressData
- * @template TDecompressException of Exception\CouldNotDecompressData
+ * @template TCompressException of Exception\Exception
+ * @template TDecompressException of Exception\Exception
  */
 abstract class XzUtils
 {
     /**
      * @param array<non-empty-string>|null $options
      *
-     * @throws TCompressException&Exception\CouldNotCompressData
+     * @throws TCompressException
      */
     final public function compress(
         string $data,
@@ -34,7 +35,7 @@ final public function compress(
     /**
      * @param array<non-empty-string>|null $options
      *
-     * @throws TDecompressException&Exception\CouldNotDecompressData
+     * @throws TDecompressException
      */
     final public function decompress(
         string $data,
@@ -48,12 +49,12 @@ final public function decompress(
     }
 
     /**
-     * @return class-string<TCompressException&Exception\CouldNotCompressData>
+     * @return class-string<TCompressException&CouldNotProcessData<string>>
      */
     abstract protected static function compressException(): string;
 
     /**
-     * @return class-string<TDecompressException&Exception\CouldNotDecompressData>
+     * @return class-string<TDecompressException&CouldNotProcessData<string>>
      */
     abstract protected static function decompressException(): string;
 

tests/XzUtilsTestCase.php

@@ -4,9 +4,11 @@
 
 namespace PetrKnap\XzUtils;
 
+use PetrKnap\Shorts\Exception\CouldNotProcessData;
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
+use Throwable;
 
 #[CoversClass(FilterFactory::class)]
 abstract class XzUtilsTestCase extends TestCase
@@ -14,16 +16,16 @@
     private const DATA_B64 = 'h/J4V2gAK1njeEOqyTiTjg==';
 
     #[DataProvider('data')]
     final public function testCompressesData(string $decompressed, string $compressed, int|null $compressionPreset): void
     {
         self::assertSame(
             bin2hex($compressed),
             bin2hex(static::getInstance()->compress($decompressed, $compressionPreset)),
         );
     }
 
     #[DataProvider('data')]
     final public function testDecompressesData(string $decompressed, string $compressed): void
     {
         self::assertSame(
             bin2hex($decompressed),
@@ -31,14 +33,22 @@
         );
     }
 
-    final public function testDecompressThrowsOnWrongData(): void
+    final public function testDecompressThrowsCorrectlyOnWrongData(): void
     {
-        self::expectException(Exception\CouldNotDecompressData::class);
+        self::expectException(Exception\Exception::class);
 
-        static::getInstance()->decompress('?');
+        try {
+            static::getInstance()->decompress('wrong data');
+        } catch (Throwable $throwable) {
+            self::assertInstanceOf(call_user_func([static::getInstance()::class, 'decompressException']), $throwable);
+            /** @var CouldNotProcessData $throwable */
+            self::assertSame('wrong data', $throwable->getData());
+
+            throw $throwable;
+        }
     }
 
     public static function data(): array
     {
         $decompressed = base64_decode(self::DATA_B64);
         $compressed = static::getCompressedDataAsBase64();