Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] video.js - optimize regex to match more youtube url cases like "shorts" #641

Merged
merged 1 commit into from
Aug 30, 2024
Merged

[Improvement] video.js - optimize regex to match more youtube url cases like "shorts" #641

merged 1 commit into from
Aug 30, 2024

Conversation

Fahl-Design
Copy link
Contributor

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Fahl-Design
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 31, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mcop1 mcop1 self-assigned this Aug 29, 2024
@mcop1 mcop1 added this to the 1.6.0 milestone Aug 30, 2024
@mcop1
Copy link
Contributor

mcop1 commented Aug 30, 2024

Thank you!

@mcop1 mcop1 merged commit 4dff99b into pimcore:1.x Aug 30, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
@Fahl-Design Fahl-Design deleted the youtube_videoid_regex_fixes branch September 2, 2024 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mcop1 mcop1

Labels
Improvement Pimcore:ToDo
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Fahl-Design @mcop1 @wisconaut