Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix print document save error #653

Merged
merged 1 commit into from
Aug 14, 2024
Merged

[Bug]: Fix print document save error #653

merged 1 commit into from
Aug 14, 2024

Conversation

kingjia90
Copy link
Contributor

@kingjia90 kingjia90 commented Aug 7, 2024

Resolves #652
Regression #622

A console.log(e) here revelead that not every document type has these buttons and could be caught by try block and display a false negative save notifcation. The save should be considered successful, so no data loss.

image

@kingjia90 kingjia90 added the Bug label Aug 7, 2024
@kingjia90 kingjia90 added this to the 1.5.3 milestone Aug 7, 2024
Copy link

sonarqubecloud bot commented Aug 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)
E Maintainability Rating on New Code (required ≥ B)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@kingjia90
Copy link
Contributor Author

kingjia90 commented Aug 7, 2024

Mhhh, another potential bug is that the buttons are overcrowded and repeated on newly created printpage and containers
image

Could you please also check if is recent change? TIA

@kingjia90 kingjia90 linked an issue Aug 7, 2024 that may be closed by this pull request
@robertSt7
Copy link
Contributor

Mhhh, another potential bug is that the buttons are overcrowded and repeated on newly created printpage and containers image

Could you please also check if is recent change? TIA

@kingjia90 This also happens in 1.5. Should we change it in this PR or create a new issue?

@kingjia90
Copy link
Contributor Author

kingjia90 commented Aug 12, 2024

I'd say maybe in a new issue, it's only a visual issue and seems not recent anyways. Thank you

@robertSt7 robertSt7 merged commit c9b60ca into 1.5 Aug 14, 2024
10 of 11 checks passed
@robertSt7 robertSt7 deleted the fix-webtoprint branch August 14, 2024 07:27
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Print document save error
3 participants