Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Asset exists check for files within folders when drag and dropping. #725

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

cancan101
Copy link
Contributor

@cancan101 cancan101 commented Oct 17, 2024

Closes #626

The asset is not correctly resolved in the exists check if it is in a folder.

Currently, the add-asset endpoint is passed the directory path but the exists endpoint is not.

@cancan101 cancan101 changed the title Fix Asset exists check for files within folders when drag and droppping. Fix Asset exists check for files within folders when drag and dropping. Oct 17, 2024
@mattamon mattamon self-assigned this Nov 13, 2024
@cancan101
Copy link
Contributor Author

any other comments on the PR?

@mattamon
Copy link
Contributor

any other comments on the PR?

Hey @cancan101,
since it is a bugfix it should go in the bugfix branch no?

@cancan101 cancan101 force-pushed the fix/folderdnd-exists branch from 38e3aa5 to c4b2cc2 Compare November 19, 2024 16:10
@cancan101 cancan101 changed the base branch from 1.x to 1.6 November 19, 2024 16:10
@cancan101 cancan101 force-pushed the fix/folderdnd-exists branch from c4b2cc2 to ce9ba2a Compare November 19, 2024 16:11
@cancan101
Copy link
Contributor Author

done

@robertSt7 robertSt7 changed the base branch from 1.6 to 1.7 December 9, 2024 13:51
Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Sorry that it took a while!

@mattamon mattamon merged commit be90baf into pimcore:1.7 Dec 13, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag and Drop Local Folder of Files on Tree View Does not Prompt for Overwrite
4 participants