Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some backend improvements:
requirements-docker.txt
file instead of therequirements.txt
file? I think that that makes everything more complex. I was hit by this, and I just did not understand what's going on: I added some dependencies torequirements.txt
on development, build the docker image, deploy it, and my dependencies were missing. Why not use the same file to build the docker image? That's what I do in the PR.update_locale
script installed in the virtualenv is wrong. What if several packages install the same script? Which one wins? Nobody knows! I was hit by this too: I had a package installed as a dependency (collective.contentrules.telegram
), which is a package generated withbobtemplates.plone
boilerplate which also installs theupdate_locale
script in bin (btw, thebackend_addon
also does this), so when runningmake i18n
in my backend add-on, the installed one was executed, and in my case thecollective.contentrules.telegram
one was executed. I guess that when runningmake i18n
in our backend folder, we want to update our own package's locales! That's what this PR does, callingupdate.sh
in this very add-on.