option to override thumb /icon behavior individually for portlet (sup… #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgrcon
force-pushed
the
plip1734thumbs
branch
6 times, most recently
from
e6ebbb0 to
c49fe62
Compare
(suppress thumbs, thumb size, suppress icons) Replace paper clip (fontello icon) with mimetype icon from mimetype registry for files plone/Products.CMFPlone#1734 (PLIP) [fgrcon]
16 tasks
jensens
reviewed
Apr 9, 2017
|
|
||
| def getMimeTypeIcon(self,obj): | ||
| fileo = obj.getObject().file | ||
| portal_url = api.portal.get().absolute_url() |
There was a problem hiding this comment.
use plone.api.portal.get_navigation_root instead, otherwise subsites and some flavors of p.a.multilingual wont work.
There was a problem hiding this comment.
this comment is wrong, use https://github.com/plone/plone.app.layout/blob/master/plone/app/layout/navigation/root.py#L11
ebrehault
approved these changes
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…press thumbs, thumb size, suppress icons)
see plone/Products.CMFPlone#1734
WIP dont merge yet