-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some files around #5334
Move some files around #5334
Conversation
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains both guide and reference material. The list of parameters might belong in a separate reference file. What do you think?
docs/source/guides/express.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has some config.settings
that might need to be moved into configuration/settings-reference.md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also there are two different settings keys, and I am not sure whether that is correct:
config.settings.serverConfig.staticFiles
config.settings.staticFiles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start. I made a couple of comments and suggestions. For this first pass, I think moving the files with only a few changes, such as moving chunks of content into a possibly more appropriate place and fixing errors and warnings, is a good strategy. Thank you!
@stevepiercy your comments on this one are more headed to do more in-depth changes (more than just moving some files around). Shouldn't we do this in the other long-lived branch/PR? I'm concerned that we don't step on each other in separated PRs. |
@sneridagh this is the long-lived branch. Although these changes would be good to backport to main, too. |
Remove ie11compat Co-authored-by: Steve Piercy <web@stevepiercy.com>
No description provided.