Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some files around #5334

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Move some files around #5334

merged 4 commits into from
Nov 7, 2023

Conversation

tiberiuichim
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for volto ready!

Name Link
🔨 Latest commit a871763
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/654a09b182969c000899978d
😎 Deploy Preview https://deploy-preview-5334--volto.netlify.app/reference/environment-variables.html
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains both guide and reference material. The list of parameters might belong in a separate reference file. What do you think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has some config.settings that might need to be moved into configuration/settings-reference.md.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also there are two different settings keys, and I am not sure whether that is correct:

  • config.settings.serverConfig.staticFiles
  • config.settings.staticFiles

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start. I made a couple of comments and suggestions. For this first pass, I think moving the files with only a few changes, such as moving chunks of content into a possibly more appropriate place and fixing errors and warnings, is a good strategy. Thank you!

docs/source/guides/ie11compat.md Outdated Show resolved Hide resolved
docs/source/guides/index.md Outdated Show resolved Hide resolved
docs/source/reference/environment-variables.md Outdated Show resolved Hide resolved
@sneridagh
Copy link
Member

@stevepiercy your comments on this one are more headed to do more in-depth changes (more than just moving some files around). Shouldn't we do this in the other long-lived branch/PR? I'm concerned that we don't step on each other in separated PRs.

@stevepiercy
Copy link
Collaborator

@sneridagh this is the long-lived branch. Although these changes would be good to backport to main, too.

tiberiuichim and others added 3 commits November 7, 2023 11:44
Remove ie11compat

Co-authored-by: Steve Piercy <web@stevepiercy.com>
@tiberiuichim tiberiuichim merged commit dd62e9a into docs-reorg Nov 7, 2023
26 of 28 checks passed
@tiberiuichim tiberiuichim deleted the docs-reorg-tibi branch November 7, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants