-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Associate labels with input fields of File and Checkbox Widget #6592
base: main
Are you sure you want to change the base?
Fix: Associate labels with input fields of File and Checkbox Widget #6592
Conversation
d31090a
to
6bd7de3
Compare
✅ Deploy Preview for plone-components canceled.
|
✅ Deploy Preview for plone-components canceled.
|
@stevepiercy @JeffersonBledsoe @davisagli Please provide review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
News looks good, with a minor tweak.
This is ready for a technical review.
f5c083b
to
53224d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
News approved. Still needs technical review. Thanks for your work!
@@ -208,6 +210,7 @@ exports[`FileWidget renders an empty file widget component 1`] = ` | |||
</div> | |||
<label | |||
class="label-file-widget-input" | |||
for="field-my-field" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abhishek-17h Modify the tests to have a different id from one test to the other so that we don't have my-field id duplication.
Then have a look at why the label My field points to the same for="field-my-field"
https://github.com/plone/volto/pull/6592/files#diff-9f7a0caef8d93ad615d7038488525d38b67b32b86153f7441bc973f60b06f713R188
53224d3
to
440ef58
Compare
440ef58
to
7c6450e
Compare
@ichim-david I’ve modified the tests to ensure each ID is unique, avoiding any duplication issues. Also I’ve verified that the label now correctly points to the associated for attribute (for="field-unique-id") in each test scenario. |
Closes #6341