fix(EffectComposer): don't skip effects when backtracking (#248)

pmndrs · Oct 24, 2023 · 41ffe02 · 41ffe02
1 parent 1f4c6c8
commit 41ffe02
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/EffectComposer.tsx b/src/EffectComposer.tsx
@@ -140,8 +140,12 @@ export const EffectComposer = React.memo(
 
             if (child instanceof Effect) {
               const effects: Effect[] = [child]
-              while (children[i] instanceof Effect && !isConvolution(children[i] as Effect)) {
-                effects.push(children[i++] as Effect)
+
+              let next: unknown = null
+              while ((next = children[i + 1]) instanceof Effect) {
+                if (isConvolution(next)) break
+                effects.push(next)
+                i++
               }
 
               const pass = new EffectPass(camera, ...effects)