unified-datetime-format (#42)

README.md

@@ -28,6 +28,7 @@ Thank you for using Nsedt. Please feel free to send pull requests, comments, and
 | symbols_list | get_symbols_list | symbols_list | -- | json |
 | asm_list | get_asm_list | symbols_list | asm_type | json |
 
+Now get_price work with start_date, end_date without datetime format it support `%d-%m-%Y`
 
 ### step to run  
 ```py

nsedt/equity.py

@@ -102,6 +102,8 @@ def get_price(
     # set the window size to one year
     window_size = datetime.timedelta(days=cns.WINDOW_SIZE)
 
+    start_date, end_date = utils.check_nd_convert(start_date, end_date)
+
     current_window_start = start_date
     while current_window_start < end_date:
         current_window_end = current_window_start + window_size

nsedt/indices.py

@@ -58,6 +58,7 @@ def get_price(
 
     # set the window size to one year
     window_size = datetime.timedelta(days=cns.WINDOW_SIZE)
+    start_date, end_date = utils.check_nd_convert(start_date, end_date)
 
     current_window_start = start_date
     while current_window_start < end_date:

nsedt/resources/constants.py

@@ -27,6 +27,7 @@
 EQUITY_CHART = "api/chart-databyindex?"
 EQUITY_INFO = "api/quote-equity?"
 EQUITY_LIST = "api/market-data-pre-open?key=ALL"
+ASM_LIST = "api/reportASM"
 
 ### Index
 INDEX_PRICE_HISTORY = "api/historical/indicesHistory?"

nsedt/utils/__init__.py

@@ -3,10 +3,13 @@
 """
 
 import json
+import deprecated
 
 import pandas as pd
 import requests
 from nsedt.resources import constants as cns
+import datetime
+from warnings import warn
 
 
 def get_headers():
@@ -100,3 +103,35 @@ def get_symbol(symbol: str, get_key: str) -> str:
             val = item[get_key]
 
     return val if val else symbol
+
+
+def check_nd_convert(start_date: str, end_date: str) -> datetime:
+    """
+    The function `check_nd_convert` takes two date strings in the format "%d-%m-%Y" and converts them to
+    datetime objects if they are not already in that format.
+
+    :param start_date: The `start_date` parameter is the starting date of a period, specified as a
+    string in the format "%d-%m-%Y"
+    :type start_date: str
+    :param end_date: The `end_date` parameter is a string representing the end date in the format
+    "%d-%m-%Y"
+    :type end_date: str
+    :return: the start_date and end_date as datetime objects.
+    """
+
+    if isinstance(start_date, datetime.date) and isinstance(end_date, datetime.date):
+        warn(
+            """Passing start_date, end_date in date is deprecated
+now pass in str '%d-%m-%Y' format""",
+            DeprecationWarning,
+            stacklevel=2,
+        )
+
+    elif isinstance(start_date, str) and isinstance(end_date, str):
+        start_date = datetime.datetime.strptime(start_date, "%d-%m-%Y")
+        end_date = datetime.datetime.strptime(end_date, "%d-%m-%Y")
+
+    else:
+        raise ("Input is of an unknown type")
+
+    return start_date, end_date

requirements.txt

@@ -1,3 +1,4 @@
 requests
 numpy
-pandas
+pandas
+Deprecated