Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports: Added logic to download bhav copy and market activity reports. #50

Merged
merged 18 commits into from
May 4, 2024

Conversation

jitendravarma
Copy link
Contributor

Added logic to process

  1. Market activity report for a given date and returns raw text (since ma report has lot many inner tables). So, I have let user decide what they want to do with raw content
  2. Added logic to download bhav copy zip

Updated Readme.

How was it tested?
Ran locally for multiple use cases.

Breaking changes: No.

Copy link
Owner

@pratik141 pratik141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test case to validate o/p is comming as expected if possible
please run Pylint also

nsedt/reports.py Outdated Show resolved Hide resolved
nsedt/reports.py Outdated Show resolved Hide resolved
@jitendravarma
Copy link
Contributor Author

Please add test case to validate o/p is comming as expected if possible please run Pylint also

Updated test cases.

@jitendravarma
Copy link
Contributor Author

Have updated logic for fake headers, as it a must for this.

tests/test_reports.py Outdated Show resolved Hide resolved
@jitendravarma
Copy link
Contributor Author

Fixed test cases and modified bhav copy download logic now supports df or json.

@pratik141 pratik141 merged commit afc9fe7 into pratik141:main May 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants