-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eager flag and set compile to be always true #734
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -228,6 +228,10 @@ def check_initialized(self): | |
f"found uninitialized parameters in model {self.__class__.__name__}: {uninitialized_parameters}" | ||
) | ||
|
||
@property | ||
def supports_cuda_graph_compilation(self) -> bool: | ||
return True | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need to set this to False for some models? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At least with the limited models I tested, compile worked so we don't set this property to False for any model, but we may want to in the future. Not needed at the moment so happy to get rid of it. |
||
|
||
@property | ||
def supports_adapter_loading(self) -> bool: | ||
return False | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this defaults to true here, will this raise an error if the user specifies
--eager
without setting anything forcompile
?Typically we would change the type of
compile
here toOption[bool]
so we can distinguish between explicitly specified args vs unspecified.