Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 카드 컴포넌트 구현 #164

Closed
wants to merge 2 commits into from
Closed

[Feat] 카드 컴포넌트 구현 #164

wants to merge 2 commits into from

Conversation

smilehae
Copy link
Member

📌 PR 설명

아주 기본적인 Card 컴포넌트를 만들었습니다.

  • CheQuiz의 대부분 컴포넌트는 사각형 구조로 되어 있습니다. 이런 구조 Container를 만들 때, 바로 가져와서 쓰도록 Base 컴포넌트로서 Card를 구현하였습니다.

💻 요구 사항과 구현 내용

e684479 Card 컴포넌트를 구현했습니다.

✔️ PR 포인트 & 궁금한 점

일단 아주 기본적이지만 필요했던, Card 컴포넌트만 구현해 놨습니다.

  • 각 파트에서 사용하고 있는 Card 비슷한 컴포넌트도 만들어 드리고 싶었는데, 스타일드 컴포넌트로만 구현하기에는 어려움이 있어 일단 보류했습니다.
  • 일단 기본적인 제가 맡은 컴포넌트는 여기까지인데, 있으면 좋겠다 하는 컴포넌트가 혹시 있을까요?
    close [Feat] 카드 컴포넌트 구현 #163

@smilehae smilehae requested review from chmini, loopy-dev and padd60 July 19, 2022 18:10
@smilehae smilehae self-assigned this Jul 19, 2022
@smilehae smilehae requested a review from Outwater July 19, 2022 18:11
@smilehae smilehae mentioned this pull request Jul 19, 2022
Open
7 tasks
loopy-dev
loopy-dev approved these changes Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@loopy-dev loopy-dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

미해님 고생하셨습니다. :) 이 PR도 인수님이랑 같이 확인했습니다!

chmini
chmini approved these changes Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@chmini chmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 수고하셨어요

padd60
padd60 approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@padd60 padd60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추상화를 잘해서 만든 컴포넌트 인거 같습니다. 추가적으로 사용하다가 커스텀할게 생기면 말씀드리겠습니다.
고생하셨습니다 ~~

@smilehae smilehae closed this Sep 18, 2022
@chmini chmini deleted the feature/163 branch November 2, 2022 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padd60 padd60 padd60 approved these changes

@loopy-dev loopy-dev loopy-dev approved these changes

@chmini chmini chmini approved these changes

@Outwater Outwater Awaiting requested review from Outwater

Assignees

@smilehae smilehae

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 카드 컴포넌트 구현
4 participants
@smilehae @chmini @loopy-dev @padd60