Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#41 - redis pub/sub 외부 메세지 브로커 사용 #50

Merged
merged 6 commits into from
Nov 28, 2024
Merged

#41 - redis pub/sub 외부 메세지 브로커 사용 #50

merged 6 commits into from
Nov 28, 2024

Conversation

Leehunil
Copy link
Collaborator

@Leehunil Leehunil commented Nov 27, 2024 •
edited
Loading

#️⃣연관된 이슈

resolved: #41

📝작업 내용

  • redis pub/sub 외부 메세지 브로커 사용
    image

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

  • redisTemplate 직렬화/역직렬화 하는데 어려웠다. 현재 GenericJackson2JsonRedisSerializer을 사용해서 직렬화를 진행하는데 추천하시는 직렬화 방식이 있으시다면 알려주세요~

@Leehunil
feat: content, imgUrls 둘 다 null일 때 예외
ba8b65c
@Leehunil
feat: redis pub/sub 사용
24ba5cc 
- redis pub/sub channel 등록
- reids listner 등록
- redisTemplate 등록
- redis publisher : channel로 publish
@Leehunil
feat: LocalDateTime 직렬화 안되는 이슈 해결
4e865b9 
- jackson-datatype-jsr310 도입
@Leehunil
feat: 이미지, 메세지 채팅 통일
ef93646 
- 하나의 DTO로 이미지, 메세지 채팅 통일
@Leehunil
test: 이미지, 메세지 채팅 통일 test 코드
232ff7c
@Leehunil
feat: websocket 통신 테스트 html 생성
d36c143
@Leehunil Leehunil added the 📌 feature New feature added label Nov 27, 2024
@Leehunil Leehunil self-assigned this Nov 27, 2024
@Leehunil Leehunil linked an issue Nov 27, 2024 that may be closed by this pull request
[Feature] - Redis pub/sub 도입 #41
Closed
1 task
@github-actions GitHub Actions
Copy link

Test Results

12 files  12 suites   11s ⏱️
48 tests 48 ✅ 0 💤 0 ❌
49 runs  49 ✅ 0 💤 0 ❌

Results for commit d36c143.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
70.5% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

jbw9964
jbw9964 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@jbw9964 jbw9964 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

src/main/java/com/palettee/chat/controller/dto/response/ChatImgUrlResponse.java Show resolved Hide resolved
kcsc2217
kcsc2217 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@kcsc2217 kcsc2217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !!!! redis 를 사용한 pub sub 저도 이전 프로젝트 업그레이드 해봐야곘네요 !!

@Leehunil Leehunil merged commit fa0ef2e into develop Nov 28, 2024
3 of 4 checks passed
@Leehunil Leehunil deleted the feature/41 branch November 28, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbw9964 jbw9964 jbw9964 approved these changes

@kcsc2217 kcsc2217 kcsc2217 approved these changes

@AnTaeho AnTaeho AnTaeho approved these changes

Assignees

@Leehunil Leehunil

Labels
📌 feature New feature added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] - Redis pub/sub 도입
4 participants
@Leehunil @AnTaeho @jbw9964 @kcsc2217