-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#32 - [Feat]
User
API 완성
#52
Conversation
+ 필요한 여러 검색 메서드 추가
+ chore: 필요한 Exception, 필터 우회 URL 추가
Test Results14 files 14 suites 14s ⏱️ Results for commit 098886f. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
전체적으로 로그를 엄청 촘촘하게 기록하시네요!
저도 나중에 코드에 남길 로그에 대해 고민해보겠습니다!
src/main/java/com/palettee/archive/repository/ArchiveCustomRepositoryImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!!! 해당 부분만 한번 확인 부탁드립니다 !!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드를 너무 깔끔하게 잘 작성해주신 것 같습니다!
궁금한 점이 한 가지 있습니다. 편하게 답변 주시면 될 것 같아요
+ refactor: `UserController` `Path Variable` `{userId}` 로 변경
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
#️⃣연관된 이슈
Close: #32
📝작업 내용
이전 완료하지 못한
User
API 부분을 완성하였습니다.유저가 등록한 Archive
와Gathering
조회는NoOffset
방식을 이용하였습니다.스크린샷 (선택)
💬리뷰 요구사항(선택)
QueryDSL
로NoOffset
을 만든 부분이 올바른지 잘 모르겠습니다.PR
취소하고 분리해 올리겠습니다.