Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#32 - [Feat] User API 완성 #52

Merged
merged 6 commits into from
Nov 29, 2024
Merged

#32 - [Feat] User API 완성 #52

merged 6 commits into from
Nov 29, 2024

Conversation

jbw9964
Copy link
Collaborator

@jbw9964 jbw9964 commented Nov 28, 2024

#️⃣연관된 이슈

Close: #32

📝작업 내용

이전 완료하지 못한 User API 부분을 완성하였습니다.

유저가 등록한 ArchiveGathering 조회는 NoOffset 방식을 이용하였습니다.

스크린샷 (선택)

캡처

💬리뷰 요구사항(선택)

  • QueryDSLNoOffset 을 만든 부분이 올바른지 잘 모르겠습니다.
  • 코드가 너무 길어 리뷰하시기 불편할 것 같습니다. 필요하면 PR 취소하고 분리해 올리겠습니다.

@jbw9964 jbw9964 added the 📌 feature New feature added label Nov 28, 2024
@jbw9964 jbw9964 self-assigned this Nov 28, 2024
Copy link

github-actions bot commented Nov 28, 2024

Test Results

14 files  14 suites   14s ⏱️
58 tests 58 ✅ 0 💤 0 ❌
59 runs  59 ✅ 0 💤 0 ❌

Results for commit 098886f.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@AnTaeho AnTaeho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
전체적으로 로그를 엄청 촘촘하게 기록하시네요!
저도 나중에 코드에 남길 로그에 대해 고민해보겠습니다!

Copy link
Collaborator

@kcsc2217 kcsc2217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!! 해당 부분만 한번 확인 부탁드립니다 !!!

Copy link
Collaborator

@Leehunil Leehunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드를 너무 깔끔하게 잘 작성해주신 것 같습니다!
궁금한 점이 한 가지 있습니다. 편하게 답변 주시면 될 것 같아요

+ refactor: `UserController` `Path Variable` `{userId}` 로 변경
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
74.5% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@jbw9964 jbw9964 merged commit 4124427 into develop Nov 29, 2024
3 of 4 checks passed
@jbw9964 jbw9964 deleted the feat/#32/user-api branch November 29, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 feature New feature added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] - User API 를 완성한다.
4 participants