Use current time as published date #656
Conversation
pete-murphy
force-pushed
the
pm/652/incorrect-time-measurements
branch
2 times, most recently
from
d07f02e to
15d747f
Compare
pete-murphy
force-pushed
the
pm/652/incorrect-time-measurements
branch
from
15d747f to
9aa8906
Compare
pete-murphy
force-pushed
the
pm/652/incorrect-time-measurements
branch
from
9aa8906 to
6da962e
Compare
scripts/src/PackageDeleter.purs
Outdated
| @@ -237,7 +237,7 @@ deleteVersion arguments name version = do | |||
| Just (Left _) -> Log.error "Cannot reimport a version that was specifically unpublished" | |||
| Just (Right specificPackageMetadata) -> do | |||
| -- Obtains `newMetadata` via cache | |||
| API.publish API.Legacy | |||
| API.publish PackageSource'Legacy | |||
There was a problem hiding this comment.
We typically only use quotes in this codebase to represent types or functions that are a tweak on another; could we use something like “LegacyPackage” and “CurrentPackage” as constructors instead?
There was a problem hiding this comment.
Yeah, sorry was intentionally leaving this as "ugly"/unconventional to remind myself to comment about alternatives and ask for suggestions about the naming, since I'm not sure what to call the type/constructors here. I'll just paste what I had started typing up in another comment:
This was originally
data Source = Legacy | Currentbut after moving to Prelude that would conflict with Source here
Current constructor here registry-dev/app/src/App/CLI/Git.purs
Line 304 in 282a4f0
Another alternative would be keeping the original constructor names but hide Current when importing in the CLI.Git module, or renaming the GitStatus constructor.
There was a problem hiding this comment.
But also happy rename things to
data PackageSource = LegacyPackage | CurrentPackageif that's preferable
There was a problem hiding this comment.
Updated 706ea23
pete-murphy
changed the title
|
Thank you @pete-murphy! |
Fixes #652