Fix bundle-app when non-node platform (#1113)

* Only add shebang when platform is node

src/Spago/Command/Bundle.purs

@@ -58,8 +58,12 @@ run = do
     -- TODO: we might need to use `Path.relative selected.path output` instead of just output there
     mainPath = withForwardSlashes $ Path.concat [ output, opts.module, "index.js" ]
 
+    shebang = case opts.platform of
+      BundleNode -> "#!/usr/bin/env node\n\n"
+      _ -> ""
+
     { input, entrypoint } = case opts.type of
-      BundleApp -> { entrypoint: [], input: Cmd.StdinWrite ("#!/usr/bin/env node\n\nimport { main } from './" <> mainPath <> "'; main();") }
+      BundleApp -> { entrypoint: [], input: Cmd.StdinWrite (shebang <> "import { main } from './" <> mainPath <> "'; main();") }
       BundleModule -> { entrypoint: [ mainPath ], input: Cmd.StdinNewPipe }
     execOptions = Cmd.defaultExecOptions { pipeStdin = input }
 

test-fixtures/bundle-app.js → test-fixtures/bundle-app-browser.js

@@ -1,4 +1,3 @@
-#!/usr/bin/env node
 (() => {
   // output/Effect.Console/foreign.js
   var log = function(s) {

test-fixtures/bundle-app-node.js

@@ -0,0 +1,15 @@
+#!/usr/bin/env node
+import __module from 'module';import __path from 'path';import __url from 'url';const require = __module.createRequire(import.meta.url);const __dirname = __path.dirname(__url.fileURLToPath(import.meta.url));const __filename=new URL(import.meta.url).pathname
+
+// output/Effect.Console/foreign.js
+var log = function(s) {
+  return function() {
+    console.log(s);
+  };
+};
+
+// output/Main/index.js
+var main = /* @__PURE__ */ log("\u{1F35D}");
+
+// <stdin>
+main();

test/Prelude.purs

@@ -80,13 +80,23 @@ shouldEqual
   -> m Unit
 shouldEqual v1 v2 =
   when (v1 /= v2) do
-    fail $ show v1 <> "\n\n≠\n\n" <> show v2
+    fail $ show v1 <> "\n\n  ≠\n\n  " <> show v2
+
+shouldEqualStr
+  :: forall m
+   . MonadThrow Error m
+  => String
+  -> String
+  -> m Unit
+shouldEqualStr v1 v2 =
+  when (v1 /= v2) do
+    fail $ "\n=====\n" <> v1 <> "\n=====\n  ≠\n=====\n  " <> show v2 <> "\n=====\n"
 
 checkFixture :: String -> String -> Aff Unit
 checkFixture filepath fixturePath = do
   filecontent <- FS.readTextFile filepath
   fixturecontent <- FS.readTextFile fixturePath
-  filecontent `shouldEqual` fixturecontent
+  filecontent `shouldEqualStr` fixturecontent
 
 plusDependencies :: Array String -> Config -> Config
 plusDependencies deps config = config

test/Spago/Bundle.purs

@@ -9,10 +9,15 @@ spec :: Spec Unit
 spec = Spec.around withTempDir do
   Spec.describe "bundle" do
 
-    Spec.it "bundles into an app" \{ spago, fixture } -> do
+    Spec.it "bundles into an app (browser)" \{ spago, fixture } -> do
       spago [ "init" ] >>= shouldBeSuccess
-      spago [ "bundle", "-v", "--bundle-type", "app", "--outfile", "bundle-app.js" ] >>= shouldBeSuccess
-      checkFixture "bundle-app.js" (fixture "bundle-app.js")
+      spago [ "bundle", "-v", "--bundle-type", "app", "--outfile", "bundle-app-browser.js" ] >>= shouldBeSuccess
+      checkFixture "bundle-app-browser.js" (fixture "bundle-app-browser.js")
+
+    Spec.it "bundles into an app (node)" \{ spago, fixture } -> do
+      spago [ "init" ] >>= shouldBeSuccess
+      spago [ "bundle", "-v", "--bundle-type", "app", "--outfile", "bundle-app-node.js", "--platform", "node" ] >>= shouldBeSuccess
+      checkFixture "bundle-app-node.js" (fixture "bundle-app-node.js")
 
     Spec.it "bundles into a module" \{ spago, fixture } -> do
       spago [ "init" ] >>= shouldBeSuccess
@@ -23,11 +28,17 @@ spec = Spec.around withTempDir do
       spago [ "bundle", "--bundle-type=module", "--outfile", "bundle-module.js" ] >>= shouldBeSuccess
       checkFixture "bundle-module.js" (fixture "bundle-module.js")
 
-    Spec.it "bundles an app with source map" \{ spago, fixture } -> do
+    Spec.it "bundles an app with source map (browser)" \{ spago, fixture } -> do
+      spago [ "init" ] >>= shouldBeSuccess
+      spago [ "bundle", "-v", "--outfile", "bundle-app-browser-map.js", "--source-maps", "--bundle-type", "app" ] >>= shouldBeSuccess
+      checkFixture "bundle-app-browser-map.js" (fixture "bundle-app-browser-map.js")
+      checkFixture "bundle-app-browser-map.js.map" (fixture "bundle-app-browser-map.js.map")
+
+    Spec.it "bundles an app with source map (node)" \{ spago, fixture } -> do
       spago [ "init" ] >>= shouldBeSuccess
-      spago [ "bundle", "-v", "--outfile", "bundle-app-map.js", "--source-maps", "--bundle-type", "app" ] >>= shouldBeSuccess
-      checkFixture "bundle-app-map.js" (fixture "bundle-app-map.js")
-      checkFixture "bundle-app-map.js.map" (fixture "bundle-app-map.js.map")
+      spago [ "bundle", "-v", "--outfile", "bundle-app-node-map.js", "--source-maps", "--bundle-type", "app", "--platform", "node" ] >>= shouldBeSuccess
+      checkFixture "bundle-app-node-map.js" (fixture "bundle-app-node-map.js")
+      checkFixture "bundle-app-node-map.js.map" (fixture "bundle-app-node-map.js.map")
 
     Spec.it "bundles a module with source map" \{ spago, fixture } -> do
       spago [ "init" ] >>= shouldBeSuccess