Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exact-match arg to git describe call #1099

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Fixes #1078

Checklist:

  • Added the change to the "Unreleased" section of the changelog
  • Added some example of the new feature to the README
  • Added a test for the contribution (if applicable)

P.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊

@JordanMartinez JordanMartinez merged commit 5884bae into master Oct 19, 2023
2 of 3 checks passed
@f-f
Copy link
Member

f-f commented Oct 19, 2023

Did you see the Windows CI failure?

@f-f f-f deleted the jam/add-exact-match branch October 19, 2023 14:34
@JordanMartinez
Copy link
Contributor Author

I did. But since the changes here don't add any test code, and the other builds passed, which means the PureScript code compiled fine, I assumed it was a flaky windows test and merged it.
I restarted the windows build here just in case and it succeeded this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag error in spago publish
2 participants