-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Troubleshoot Windows Bundle Failure #1115
Closed
CharlesTaylor7
wants to merge
19
commits into
master
from
windows-bundle-failure-minimal-reproduction
Closed
Troubleshoot Windows Bundle Failure #1115
CharlesTaylor7
wants to merge
19
commits into
master
from
windows-bundle-failure-minimal-reproduction
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlesTaylor7
changed the title
Troubleshoot Windows Bundle Failure
Fix: Error message when Nov 13, 2023
purs
is not on path
CharlesTaylor7
deleted the
windows-bundle-failure-minimal-reproduction
branch
November 13, 2023 16:29
CharlesTaylor7
changed the title
Fix: Error message when
Troubleshoot Windows Bundle Failure
Nov 13, 2023
purs
is not on path
f-f
reviewed
Nov 13, 2023
@@ -118,7 +118,7 @@ getExecutable command = | |||
Right r -> pure { cmd: cmd1, output: r.stdout } | |||
Left err' -> do | |||
let cmd2 = mkCmd command Nothing | |||
logDebug [ "Failed to find purs.cmd. Trying with just purs...", show err' ] | |||
logDebug [ "Failed to find ", command, ".cmd. Trying with just purs...", show err' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll want this change merged or this log will be very confusing 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.