Add validation for OSV records #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di
approved these changes
Nov 21, 2024
|
I've made this a required check as well. |
|
I'd be better to not rely on a forked copy of the OSV-Schema, it will continue to evolve over time. |
|
@andrewpollock You're suggesting we take it from here instead? https://github.com/ossf/osv-schema/blob/main/validation/schema.json |
| hooks: | ||
| - id: check-jsonschema | ||
| files: "^vulns/[a-z0-9_-]+/.+\\.yaml" | ||
| args: [--schemafile, "./.github/osv-schema.json"] |
There was a problem hiding this comment.
@di if I'm understanding the implementation correctly, based on https://check-jsonschema.readthedocs.io/en/latest/usage.html#downloading-and-caching it can be invoked as
--schemafile https://raw.githubusercontent.com/ossf/osv-schema/main/validation/schema.json or --schemafile https://raw.githubusercontent.com/ossf/osv-schema/refs/tags/v1.6.7/validation/schema.json if you wanted to explicitly pin to a version
andrewpollock
added a commit
to google/osv.dev
that referenced
this pull request
Dec 2, 2024
…#2943) This enables strict mode in the OSV.dev staging environment for all sources in staging that have been deemed already be publishing 100% OSV JSON Schema compliant records, with the notable exception of the RustSec Advisory Database due to rustsec/advisory-db#2135 and the inclusion of PyPA despite pypa/advisory-database#217 (because of pypa/advisory-database#208) Part of #2188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73