Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfill fix versions where possible from GitHub Security Advisories #211

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Nov 22, 2024

Related to: #205 I'm not sure if we can un-withdraw a record?

@di
Copy link
Member

di commented Nov 22, 2024

I'm not sure if we can un-withdraw a record?

I'm also not sure what will happen here if we remove the withdrawn field after the fact. 🫤

@sethmlarson
Copy link
Contributor Author

@andrewpollock @oliverchang What happens if we un-withdraw, is that allowed? Or should we create a new record?

@andrewpollock
Copy link

@andrewpollock @oliverchang What happens if we un-withdraw, is that allowed? Or should we create a new record?

Transitions are supported 👍

@andrewpollock
Copy link

Transitions are supported 👍

Please do ensure you update the modified time to reflect the changes being made

Copy link
Contributor

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

As @andrewpollock mentions it's OK to unwithdraw, but we need to make sure we update the modified field here.

@sethmlarson sethmlarson force-pushed the backfill-fix-versions-for-records branch from ac0fb74 to 7c05abd Compare November 25, 2024 19:30
@sethmlarson sethmlarson force-pushed the backfill-fix-versions-for-records branch from 61e91a0 to 27b0542 Compare November 25, 2024 19:50
@sethmlarson
Copy link
Contributor Author

@oliverchang @andrewpollock Thanks for confirming, I've updated the modified field for all the records too.

@di
Copy link
Member

di commented Nov 25, 2024

FYI, there are merge conflicts here now.

@sethmlarson sethmlarson force-pushed the backfill-fix-versions-for-records branch from 9ede387 to ea48710 Compare November 25, 2024 22:20
@sethmlarson sethmlarson merged commit faaf77b into pypa:main Nov 25, 2024
1 check passed
@sethmlarson sethmlarson deleted the backfill-fix-versions-for-records branch November 25, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants