Rewrite pyRevit configurations

[dosymep]

• added config abstraction
• added config overrides (need testing and design the logic of work)
• replace ini lib to ini-parser
• added json configuration
• added yaml configuration (doesn't work I need to figure out the parser library)

I think in general a start has been made, it remains to rewrite the logic of the config in python

[dosymep]

@jmcouffin @sanzoghenzo how to trigger github action?

[jmcouffin]

@jmcouffin @sanzoghenzo how to trigger github action?

[jmcouffin]

I just launched it.
15min+ to go

I won't be able to review just now, best I can do is install the wip that will be created

[sanzoghenzo]

Awesome job @dosymep !

I didn't run the code, only skimmed through, and only found some grammar to fix (ShouldThrows -> ShouldThrow).

Do you think it would be worth creating separate repo(s) and nuget package(s) for this feature (just to start the transition to a better code structure)?

[dosymep]

creating separate repo(s) and nuget package(s)

it won't work, we have dependencies on this repo, at the moment I still don't know how to do this :(

[sanzoghenzo]

HI @dosymep,

The attributes solution is really nice!

Just one question, out of curiosity: why did you turn GetValueImpl into a non-generic method? wouldn't it work the same?

[dosymep]

@sanzoghenzo
I updated internal API, to get values from reflection

https://github.com/pyrevitlabs/pyRevit/pull/2482/files#diff-3e1f8a1b067a136ccc1a3c88ee1bf54a3f0dac93b46c9ba785d9e86096f5e7c6R152

[sanzoghenzo]

@sanzoghenzo I updated internal API, to get values from reflection

https://github.com/pyrevitlabs/pyRevit/pull/2482/files#diff-3e1f8a1b067a136ccc1a3c88ee1bf54a3f0dac93b46c9ba785d9e86096f5e7c6R152

Yes I saw that, i should have asked you "why can't you use generics with reflection?" but it doesn't matter as long as it works! 😉 it is just something I have to learn about .net...

[dosymep]

Yes I saw that, i should have asked you "why can't you use generics with reflection?" but it doesn't matter as long as it works! 😉 it is just something I have to learn about .net...

because when I ask property type from reflections, reflection api return me an object of the Type. I can't pass it as a generic parameter

[dosymep]

remaining

• write tests
• write code in python
• fix tests

[sanzoghenzo]

As for the python side, do you think that we can directly use these new classes in the userconfig.py?

Are user-defined sections and keys supported?

[dosymep]

As for the python side, do you think that we can directly use these new classes in the userconfig.py?
Are user-defined sections and keys supported?

1 yep
2 yep
but need check :D