Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow python version=3.12 in docker script build_image.sh #3332

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

allow python version=3.12 in docker script build_image.sh #3332

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64e58d6
allow python version=3.12 in docker script build_image.sh
fabridamicelli Oct 1, 2024
777dc77
Merge branch 'master' into docker_bump_valid_py_version
fabridamicelli Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docker/build_image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ do
echo "-lf, --use-local-serve-folder specify this option for the benchmark image if the current 'serve' folder should be used during automated benchmarks"
echo "-ipex, --build-with-ipex specify to build with intel_extension_for_pytorch"
echo "-cpp, --build-cpp specify to build TorchServe CPP"
echo "-py, --pythonversion specify to python version to use: Possible values: 3.8 3.9 3.10"
echo "-py, --pythonversion specify to python version to use: Possible values: 3.8 3.9 3.10 3.11 3.12"
echo "-n, --nightly specify to build with TorchServe nightly"
echo "-s, --source specify to build with TorchServe from source"
echo "-r, --remote specify to use local TorchServe"
Expand Down Expand Up @@ -113,10 +113,10 @@ do
;;
-py|--pythonversion)
PYTHON_VERSION="$2"
if [[ $PYTHON_VERSION = 3.8 || $PYTHON_VERSION = 3.9 || $PYTHON_VERSION = 3.10 || $PYTHON_VERSION = 3.11 ]]; then
if [[ $PYTHON_VERSION = 3.8 || $PYTHON_VERSION = 3.9 || $PYTHON_VERSION = 3.10 || $PYTHON_VERSION = 3.11 || $PYTHON_VERSION = 3.12 ]]; then
echo "Valid python version"
else
echo "Valid python versions are 3.8, 3.9 3.10 and 3.11"
echo "Valid python versions are 3.8, 3.9, 3.10, 3.11 and 3.12"
exit 1
fi
shift
Expand Down