-
-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animated marker added to Symbology #8568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@selmaVH1 I think we need to showcase this type of symbol and an animation would probably be appropriate... maybe the first one in the issue report?
|
||
Animated marker symbol type allows you to use animated markers, which can be | ||
GIFs, WebP, or MNG animations, to represent points on your map. You | ||
can specify marker ``file``, ``size``, ``angle``, and ``frame rate``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can specify marker ``file``, ``size``, ``angle``, and ``frame rate``. | |
You can specify: | |
* :guilabel:`File` path, | |
* :guilabel:`Frame rate`: number of steps that are shown per second, | |
indicating how fast the animation is played | |
* :guilabel:`Size` in any :ref:`supported unit <supported_units>`, | |
* :guilabel:`Opacity`, | |
* :guilabel:`Rotation`, | |
* :guilabel:`Offset` in :guilabel:`x` and :guilabel:`y` directions from the marker position | |
* :guilabel:`Anchor point` |
The description in issue report is generally an indication and can't be simply taken as is without checking the current GUI (and sometimes playing with the feature). It happens that there are more details or things have changed in the meantime.
@DelazJ can you, please review this PR again? I added both animations, they can be helpful. I have also removed paragraph titles, so now everything is in one paragraph, but I'm still not sure is it clear enough for users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing, I added screenshots for PDF,
There are many settings in play for this feature so I'm not really convinced that we can showcase it with an image. And since we can't play svg in a pdf, we keep them for the html build only (
but I can't create preview for PDF so I'm not sure is it ok...
The build has failed due to a wrong ref but when succeeded, if you follow the details link next to the build reports
and click [summary] in the top left of the page, you would get a way to download a build of the html and pdf outputs
You can also enable these builds in your fork, so that you checked this even before opening a PR
.. figure:: /docs/user_manual/style_library/img/animated_marker_map.* | ||
:align: center | ||
:width: 100% | ||
|
||
Animated marker when map is not configured as animation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. figure:: /docs/user_manual/style_library/img/animated_marker_map.* | |
:align: center | |
:width: 100% | |
Animated marker when map is not configured as animation | |
.. only:: html | |
.. figure:: img/animated_marker_map.svg | |
:align: center | |
:width: 100% | |
Animated marker when map is not configured as animation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮 svg? I should stop review when too late..
.. figure:: /docs/user_manual/style_library/img/animated_marker_animation.* | ||
:align: center | ||
:width: 100% | ||
|
||
Animated marker when map is configured as animation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. figure:: /docs/user_manual/style_library/img/animated_marker_animation.* | |
:align: center | |
:width: 100% | |
Animated marker when map is configured as animation | |
.. only:: html | |
.. figure:: img/animated_marker_animation.svg | |
:align: center | |
:width: 100% | |
Animated marker when map is configured as animation |
* :guilabel:`File` path, | ||
* :guilabel:`Frame rate`: number of steps that are shown per second, | ||
indicating how fast the animation is played, | ||
* :guilabel:`Size` in any :ref:`supported unit <supported_units>`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* :guilabel:`Size` in any :ref:`supported unit <supported_units>`, | |
* :guilabel:`Size` in any :ref:`supported unit <unit_selector>`, |
oups, sorry!
|
||
.. only:: html | ||
|
||
.. figure:: /docs/user_manual/style_library/img/animated_marker_map.gif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole block with caption should be indented, under the only...
block. And use relative path to file. See my previous suggestion
fixes #7468
Animated marker added to the Style library.