Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Thread Signal #849

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

New Thread Signal #849

wants to merge 2 commits into from

Conversation

nvrWhere
Copy link
Collaborator

@nvrWhere nvrWhere commented Jan 2, 2025

Add a signal for when a new thread is created in the room which is useful for when an exisiting event is turned into a thread.

@nvrWhere
Add a signal for when a new thread is created in the room which is us…
93ef9a5 
…eful for when an exisiting event is turned into a thread.
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

KitsuneRal
KitsuneRal reviewed Jan 2, 2025
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM but isNew could be const and then reused as the branching condition, rather than the other way around.

Quotient/room.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KitsuneRal KitsuneRal KitsuneRal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvrWhere @KitsuneRal