Create sudoers file internally instead of calling limactl sudoers
#7966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `limactl sudoers` command will fail if socket_vmnet is not yet installed into the secure path. So we would need to ask the user for the sudo password twice: once to install socket_vmnet, and then again to install the sudoers file. By "guessing" the content beforehand we can install both at the same time. Signed-off-by: Jan Dubois <jan.dubois@suse.com> (cherry picked from commit 2fabc34)
Nino-K
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
limactl sudoerscommand will fail if socket_vmnet is not yet installed into the secure path. So we would need to ask the user for the sudo password twice: once to install socket_vmnet, and then again to install the sudoers file. By "guessing" the content beforehand we can install both at the same time.Signed-off-by: Jan Dubois jan.dubois@suse.com
(cherry picked from commit 2fabc34)