Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSL: Handle eth0 being renamed #7995

Closed
wants to merge 1 commit into from

Conversation

mook-as
Copy link
Contributor

@mook-as mook-as commented Dec 21, 2024

Change how we parse for the current IP address in WSL so that we don't rely on the interface being named eth0. Fixes #7989 (where it's named eth3 instead).

We blacklist localhost, docker0, cni0, veth…, etc. The actual parsing parse is refactored into a separate function so it can be tested easier.

Signed-off-by: Mark Yen <mark.yen@suse.com>
@mook-as mook-as requested a review from Nino-K January 7, 2025 17:51
@mook-as
Copy link
Contributor Author

mook-as commented Jan 7, 2025

We may not need this as the original reporter had networkingmode=mirrored on and that should be fixed already in 1.17.

@mook-as
Copy link
Contributor Author

mook-as commented Jan 8, 2025

Yep, turned out to be networkingmode=mirrored, and it works fine in 1.17 because of #7577.

@mook-as mook-as closed this Jan 8, 2025
@mook-as mook-as deleted the win32/wsl-eth-not-eth0 branch January 8, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Waiting on Kubernetes API on startup
1 participant