Windows: Don't abort everything if $HOME is not writable
#8042
+159
−43
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import { DiagnosticsCategory, DiagnosticsChecker, DiagnosticsCheckerResult, DiagnosticsCheckerSingleResult } from './types'; | ||
|
|
||
| import mainEvents from '@pkg/main/mainEvents'; | ||
|
|
||
| const cachedResults: Record<string, DiagnosticsCheckerResult> = {}; | ||
|
|
||
| const CheckWindowsIntegrations: DiagnosticsChecker = { | ||
| id: 'WINDOWS_INTEGRATIONS', | ||
| category: DiagnosticsCategory.ContainerEngine, | ||
| applicable() { | ||
| return Promise.resolve(process.platform === 'win32'); | ||
| }, | ||
| check(): Promise<DiagnosticsCheckerSingleResult[]> { | ||
|
There was a problem hiding this comment. It's a little hard to see what's happening here should it be broken down to: There was a problem hiding this comment. Fixed in 6e1d40a (I factored out the inner map function instead, and Nino seems okay with that). |
||
| const resultMapper = ([id, result]: [string, DiagnosticsCheckerResult]) => { | ||
| return ({ ...result, id }); | ||
| }; | ||
|
|
||
| return Promise.resolve(Object.entries(cachedResults).map(resultMapper)); | ||
| }, | ||
| }; | ||
|
|
||
| mainEvents.on('diagnostics-event', (payload) => { | ||
| if (payload.id !== 'integrations-windows') { | ||
| return; | ||
| } | ||
| const { distro, key, error } = payload; | ||
| const message = error?.message ?? error?.toString(); | ||
|
|
||
| cachedResults[`${ distro || '<main>' }-${ key }`] = { | ||
| passed: false, | ||
| fixes: [], | ||
| ...(() => { | ||
| if (!error) { | ||
| return { passed: true, description: `${ distro }/${ key } passed` }; | ||
| } | ||
| if (distro) { | ||
| return { description: `Error managing distribution ${ distro }: ${ key }: ${ message }` }; | ||
| } | ||
|
|
||
| return { description: `Error managing ${ key }: ${ message }` }; | ||
| })(), | ||
| }; | ||
| }); | ||
|
|
||
| export default CheckWindowsIntegrations; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think this needs a check for the input key? e.g.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because
keyis not optional (distroanderrorare), per TypeScript annotations. Also, this is aprotectedmethod, so we should be able to expect the callers to be type-checked.