Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include leading v in dependencies.yaml for check-spelling #8067

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

jandubois
Copy link
Member

Use the same format and logic as for all other GitHub based releases.

Use the same format and logic as for all other GitHub based releases.

Signed-off-by: Jan Dubois <jan.dubois@suse.com>
@jandubois jandubois requested a review from mook-as January 10, 2025 19:54
Copy link
Contributor

@mook-as mook-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume yq failure will still abort the script?

@mook-as mook-as merged commit efccd37 into rancher-sandbox:main Jan 10, 2025
20 checks passed
@jandubois jandubois deleted the rddepman-check-spelling branch January 10, 2025 22:42
@jandubois
Copy link
Member Author

I assume yq failure will still abort the script?

I think so:

foo="v$(false)"; echo $?
1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants