-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dask_expr
migration into dask.dataframe
#17704
base: branch-25.02
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I guess, we expect the dask>2024.12.1
pinning fairly soon right? Otherwise, we might consider moving all of the dask_expr
imports to a centralized place.
I think we will either stay pinned to
Yeah, totally agree. I actually tried this initially, but I struggled to find a structure I was happy with. That said, I could be missing an obvious design pattern that would have made everything cleaner. |
I think it is fine as is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes mostly make sense to me except for the message to downgrade for which I left a comment. WDYT @rjzamora ?
Description
Follow up to #17558
This PR cleans up some imports and provides support for both
dask:2024.12.1
anddask:main
(in whichdask_expr
has been moved into thedask.dataframe
module).See also: rapidsai/dask-cuda#1424
Checklist