Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dask_expr migration into dask.dataframe #17704

Open
wants to merge 7 commits into
base: branch-25.02
Choose a base branch
from

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented Jan 9, 2025

Description

Follow up to #17558
This PR cleans up some imports and provides support for both dask:2024.12.1 and dask:main (in which dask_expr has been moved into the dask.dataframe module).

See also: rapidsai/dask-cuda#1424

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added feature request New feature or request 2 - In Progress Currently a work in progress non-breaking Non-breaking change labels Jan 9, 2025
@rjzamora rjzamora self-assigned this Jan 9, 2025
@rjzamora rjzamora requested a review from a team as a code owner January 9, 2025 15:40
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jan 9, 2025
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I guess, we expect the dask>2024.12.1 pinning fairly soon right? Otherwise, we might consider moving all of the dask_expr imports to a centralized place.

@rjzamora
Copy link
Member Author

I guess, we expect the dask>2024.12.1 pinning fairly soon right?|

I think we will either stay pinned to dask:2024.12.1 for rapids:25.02 (but continue efforts like this to stay as aligned with dask:main as possible), or we will end up pinning to 2025.1.<something> in the next two weeks.

Otherwise, we might consider moving all of the dask_expr imports to a centralized place.

Yeah, totally agree. I actually tried this initially, but I struggled to find a structure I was happy with. That said, I could be missing an obvious design pattern that would have made everything cleaner.

@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 2 - In Progress Currently a work in progress labels Jan 11, 2025
@madsbk
Copy link
Member

madsbk commented Jan 13, 2025

Yeah, totally agree. I actually tried this initially, but I struggled to find a structure I was happy with. That said, I could be missing an obvious design pattern that would have made everything cleaner.

I think it is fine as is

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes mostly make sense to me except for the message to downgrade for which I left a comment. WDYT @rjzamora ?

python/dask_cudf/dask_cudf/_expr/__init__.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants