-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NumPy <2 pin #1375
Remove NumPy <2 pin #1375
Conversation
Closing and reopening to rerun CI with CuPy 13.3.0 (since it was released earlier today) |
It is worth noting that there is a cycle in the dependency graph between cuDF requiring Dask-CUDA in its tests and Dask-CUDA requiring cuDF Unfortunately that means to test either one with NumPy 2, we need to rebuild both with NumPy 2 first. Since it is not possible to rebuild both and test at the same time, we need to pick one to rebuild first so we can test the other Given Dask-CUDA's library usage of NumPy 2 is relatively simple (wrapping memory and very minor adjustments), rebuilding Dask-CUDA first seems like the safer path. We can then rebuild and test cuDF with NumPy 2 and Dask-CUDA. Once cuDF packages are out we can come back and test Dask-CUDA on NumPy 2 (using a no-op PR to run CI tests and spot checking CI logs for NumPy 2 usage with cuDF) Leaving this note for completeness about this plan. Will also link the no-op testing PR here |
Should add, ran a quick sanity check using Ruff's NumPy 2 plugin and it came back clean
So hopefully that provides us some more confidence (in addition to repeated offline testing done as part of NumPy 2 bringup, CuPy 13.3.0 development, etc.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sebastian! 🙏
/merge |
Will use PR ( #1378 ) for testing |
This PR removes the NumPy<2 pin which is expected to work for
RAPIDS projects once CuPy 13.3.0 is released (CuPy 13.2.0 had
some issues preventing the use with NumPy 2).