Continue to make KvikIO a shared library by moving code from hpp to cpp #581
Conversation
kingcrimsontianyu
added
non-breaking
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
/ok to test |
|
/ok to test |
kingcrimsontianyu
added
breaking
|
/ok to test |
| /* | ||
| * Copyright (c) 2025, NVIDIA CORPORATION. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #include <kvikio/error.hpp> |
There was a problem hiding this comment.
I'd like to have a .cpp file for each .hpp (except cuda/cufile_h_wrapper.hpp). But it's just a matter of style. You make the call please 😄
There was a problem hiding this comment.
I think I lean more to no empty .cpp :)
We could implement the body of the error macros in regular detail functions; to make them more readable and also give error.cpp something to do :P
There was a problem hiding this comment.
Good idea. The catch is that the 3 macros defined in error.hpp have an optional second parameter _exception_type which is a type. So I only managed to improve the readability by moving most of the macro content to template functions. error.cpp still has no wine.
Let me know if the new change is worth keeping.
In light of the initiative to make KvikiIO a shared library, this PR further separates the implementation from the interface as thoroughly as possible.
This PR is marked "breaking" because:
getenv_orinitially in thedetailnamespace has been moved outside to become part of the public API. cuDF uses this function and needs a timely code update.detailnamespace for internal use only have been relocated to the.cppfiles, so downstream applications that happen to use those entities will now see compile errors.Notes:
[[nodiscard]]in the header now have them in the declaration (.hpp) only, not in the definition (.cpp).detailnamespace fromX.hppare now moved to the unnamed namespace in theX.cppfiles, unless they are used elsewhere (e.g.Y.cpp).