Compile spdlog with fpic and hide symbols for good measure

rapidsai · Jan 8, 2025 · 20c7d97 · 20c7d97
1 parent d340f86
commit 20c7d97
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/rapids-cmake/cpm/rapids_logger.cmake b/rapids-cmake/cpm/rapids_logger.cmake
@@ -70,6 +70,10 @@ function(rapids_cpm_rapids_logger)
                                    # some tweaking of argument forwarding I suspect.
                                    CPM_ARGS EXCLUDE_FROM_ALL ON OPTIONS "BUILD_SHARED_LIBS OFF"
                                    "SPDLOG_BUILD_SHARED OFF")
+      # TODO: Propagate the visibility settings to the export set as well.
+      set_target_properties(spdlog
+                            PROPERTIES CXX_VISIBILITY_PRESET hidden VISIBILITY_INLINES_HIDDEN ON
+                                       POSITION_INDEPENDENT_CODE ON)
 
       # Instead of passing build and install export sets to rapids_cpm_spdlog we call
       # rapids_export_cpm directly for both the build and install export sets to support force