proprietary_binary now supports cuda toolkit version placeholders #377
Conversation
robertmaynard
added
feature request
This will allow rapids_cpm to customize download urls based on the CUDA Toolkit version.
robertmaynard
force-pushed
the
version_ctk_version_keyword
branch
from
d73362d to
a8ff7fa
Compare
| "test_binary" : { | ||
| "version" : "2.6.1", | ||
| "proprietary_binary" : { | ||
| "x86_64-linux" : "https://fake.url.com/${version}/${cuda-toolkit-version}/x86_64_${cuda-toolkit-version-major}.tgz", |
There was a problem hiding this comment.
I assume the answer is no since it's kind of the whole point of bracket expressions, but just in case: is there any way to force variable evaluation inside brackets? It would be nice to not need to repeat the URL every time.
There was a problem hiding this comment.
You mean the fact that we have both x86 and arm? It is an explicit choice so that we can explicitly state support for multiple platforms in a easy to understand manner.
To have only a single url we would need:
- Introduce a key named
all_platforms - Add extra keys / values to
proprietary_binarythat mapped from the system arch ( x86 / arm ) to the placeholders used by that package in the download url
There was a problem hiding this comment.
No, I just mean the repetition of the domain in the URL https://fake.url.com.
There was a problem hiding this comment.
That is a good idea. Want to create an issue for that and we can iterate on it independent of this PR?
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
|
/merge |
Description
This will allow rapids_cpm to customize download urls based on the CUDA Toolkit version.
Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))