Retain instead of truncate unknown flags when converting to bitflags
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
bitflags-lossless
branch
from
31caa61 to
0782078
Compare
`bitflags` intrinsically supports holding unknown flag values, and pretty-printing a non-zero hex code if there are any. This should make our conversion functions lossless and allow us/users to more easily spot new, unsupported constants.
MarijnS95
force-pushed
the
bitflags-lossless
branch
from
0782078 to
cc704c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #79
bitflagsintrinsically supports holding unknown flag values, and pretty-printing a non-zero hex code if there are any. This should make our conversion functions lossless and allow us/users to more easily spot new, unsupported constants.