Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control: Add Type::Unknown #99

Merged
merged 1 commit into from
May 5, 2024
Merged

control: Add Type::Unknown #99

merged 1 commit into from
May 5, 2024

Conversation

MarijnS95
Copy link
Collaborator

@MarijnS95 MarijnS95 commented Apr 8, 2024

Fixes #98

Draft change to make conversion from v4l2_query_ext_ctrl to Description - and within it u32 to a Type - fallible rather than panicking on unknown type values.

This approach includes a few breaking changes, to store the unknown type in the struct. Alternatively we could make the entire conversion for v4l2_query_ext_ctrl fallible via TryFrom?

@MarijnS95 MarijnS95 force-pushed the control-type-unknown branch from d5c423e to 6e1fc22 Compare May 2, 2024 22:58
@MarijnS95 MarijnS95 marked this pull request as ready for review May 2, 2024 22:58
@raymanfx raymanfx merged commit 6d17141 into master May 5, 2024
10 checks passed
@MarijnS95 MarijnS95 deleted the control-type-unknown branch May 5, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic: v4l-0.14.0/src/control.rs:172:45: called Result::unwrap() on an Err value: ()
2 participants