Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppKit] bug fixes for social logins #38

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

quetool
Copy link
Member

@quetool quetool commented Nov 20, 2024

Description

  • Fixes a bug where no username was showing up when logged in with Apple
  • Fixes a bug where signOutOnNetworkChange policy from SIWE config was not working.

Resolves #37

How Has This Been Tested?

Extensive manual test

Due Dilligence

  • Breaking change
  • Requires a documentation update

@quetool quetool merged commit 9c46248 into develop Nov 20, 2024
1 check passed
@quetool quetool deleted the bugfix/social_email_not_showing branch December 13, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple signin does not populate email address (used to work)
1 participant