Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker example and documentation. #168

Merged
merged 9 commits into from
Dec 23, 2024
Merged

Add docker example and documentation. #168

merged 9 commits into from
Dec 23, 2024

Conversation

ilan-theodoro
Copy link
Member

@ilan-theodoro ilan-theodoro commented Dec 5, 2024

Some key features:

  • Script for automating the build of an ultrack image based on the current pypi version and available torch pre-configured containers.
  • Installation of cucim and its dependencies on GPU supported containers.
  • Tutorial on serving jupyter notebook inside the container.
  • Tutorial on using the Gurobi WLS license.
  • README documentation

But some minor issues might be addressed:

  • Ultrack installs nvidia related libraries even when not asked, which creates bloated CPU containers.
  • Ideally, the README should be on the documentation page.
  • We must create a royerlab or ultrack page on DockerHub.

@ilan-theodoro ilan-theodoro marked this pull request as draft December 5, 2024 22:54
@ilan-theodoro ilan-theodoro requested a review from JoOkuma December 5, 2024 22:55
Copy link
Member

@JoOkuma JoOkuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ilan-theodoro , sorry for the delay to review this.
I don't have any major comments, everything looks great.

I agree with both points, could you include them in this PR?

  • Ideally, the README should be on the documentation page.
  • We must create a royerlab or ultrack page on DockerHub.

Ultrack installs nvidia related libraries even when not asked, which creates bloated CPU containers.

I think using

pip install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cpu

before installing ultrack will install torch with CPU only

examples/docker/cpu/Dockerfile Outdated Show resolved Hide resolved
@ilan-theodoro ilan-theodoro marked this pull request as ready for review December 20, 2024 00:20
@JoOkuma
Copy link
Member

JoOkuma commented Dec 20, 2024

I created #171 to fix the CI issues

@JoOkuma
Copy link
Member

JoOkuma commented Dec 20, 2024

@ilan-theodoro great PR.
I moved the position of the docker on the documentation because I want people to use it as a last resource.
Any comments?
Otherwise, I think we can merge this; thanks for this PR.

docker/cpu/Dockerfile Show resolved Hide resolved
@JoOkuma JoOkuma merged commit fe8b759 into main Dec 23, 2024
0 of 7 checks passed
@JoOkuma JoOkuma deleted the docker-support branch December 23, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants