Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootc: Document --transient and persistence #2186

Open
wants to merge 1 commit into
base: bootc
Choose a base branch
from

Conversation

evan-goode
Copy link
Member

Documents the new --transient command-line argument and persistence configuration option. I tried to use a table for listing the valid options for persistence, but RST does not automatically wrap table cells containing long lines, so a list was much easier.

This is a follow-up to #2155.

Copy link
Contributor

@dcantrell dcantrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some rewording ideas. I am ok with what's there, so take or ignore my suggestions.

.. _transient_option-label:

``--transient``
Applicable only on bootc systems. Perform transactions using a transient overlay which will reset on reboot. See also the :ref:`persistence <persistence-label>` configuration option.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Applicable only on bootc systems." looks strange to me. Almost like bootc is a typo. Given that this is documentation, I'd recommend something else along with 'bootc' to make it clear this is for systems managed by the bootc tool or something.

"which will reset on reboot" also comes across strangely. I would say "which will be lost on the next reboot".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this to "Applicable only on bootc (bootable containers) systems." I think "bootc systems" is common enough in RHEL docs at this point: https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/9/html/using_image_mode_for_rhel_to_build_deploy_and_manage_operating_systems/managing-kernel-arguments-in-bootc-systems#managing-kernel-arguments-in-bootc-systems.

IMO the best thing would be to link to https://github.com/containers/bootc but not sure whether that's appropriate for this man page.

doc/conf_ref.rst Outdated Show resolved Hide resolved
doc/conf_ref.rst Outdated Show resolved Hide resolved
Documents the new `--transient` command-line argument and `persistence`
configuration option. I tried to use a table for listing the valid
options for `persistence`, but RST does not automatically wrap table
cells containing long lines, so a list was much easier.
@evan-goode evan-goode force-pushed the evan-goode/document-transient branch from f7aa7ec to b87a94b Compare January 8, 2025 19:34
@evan-goode evan-goode requested a review from dcantrell January 8, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants