Merge pull request #288 from rsksmart/feature/GBI-2374

Feature/GBI-2374 - basic.test.js migration

.github/workflows/ci.yml

@@ -7,7 +7,6 @@ on:
   push:
     branches: [master, Stable-Test, QA-Test]
   pull_request:
-    branches: [master, Stable-Test, QA-Test]
 
   # Allows you to run this workflow manually from the Actions tab
   workflow_dispatch:
@@ -27,21 +26,28 @@ jobs:
       # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
       - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
 
-      - name: Use Node.js 19.6.0
+      - name: Use Node.js 20.15.1
         uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
         with:
-          node-version: "19.6.0"
-
-      - name: Install truffle
-        run: npm install -g truffle
+          node-version: "20.15.1"
 
       - name: NPM Login
-        run: npm config set //npm.pkg.github.com/:_authToken ${{ secrets.GITHUB_TOKEN }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: npm config set //npm.pkg.github.com/:_authToken $GITHUB_TOKEN
 
       - name: Install dependencies
         run: npm ci
-      # - name: Lint source and tests
-      #   run: npm run lint
+
+      - name: Lint contracts
+        run: npm run lint:sol
+
+      - name: Compile contracts
+        run: npm run compile
+
+      - name: Lint test and scripts
+        run: npm run lint:ts
+
       - name: Unit test smart contracts
         run: npm test
       # - name: Coverage report

eslint.config.mjs

@@ -8,6 +8,7 @@ export default [
   { languageOptions: { globals: globals.node } },
   {
     ignores: [
+      "eslint.config.mjs",
       "typechain-types/*",
       "node_modules/*",
       "artifacts/*",
@@ -24,5 +25,19 @@ export default [
     ],
   },
   pluginJs.configs.recommended,
-  ...tseslint.configs.recommended,
+  ...tseslint.configs.strictTypeChecked,
+  ...tseslint.configs.stylisticTypeChecked,
+  {
+    rules: {
+      "@typescript-eslint/no-non-null-assertion": "off",
+    },
+  },
+  {
+    languageOptions: {
+      parserOptions: {
+        projectService: true,
+        tsconfigRootDir: import.meta.dirname,
+      },
+    },
+  },
 ];