Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Fix Dark mode and responsiveness on PageRSEProtocols #372 #403

Closed
wants to merge 3 commits into from

Conversation

esilvaju
Copy link
Contributor

Fix Dark mode and responsiveness on PageRSEProtocols

Eraldo Junior and others added 2 commits October 5, 2023 17:49
@esilvaju esilvaju added the bug Something isn't working label Mar 12, 2024
@esilvaju esilvaju requested a review from maany March 12, 2024 13:56
@esilvaju esilvaju self-assigned this Mar 12, 2024
Copy link
Member

@maany maany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would recommend that we use TailwindCSS breakpoints over useResponsive Hook.

src/component-library/Pages/RSE/PageRSEProtocols.tsx Outdated Show resolved Hide resolved
Comment on lines +41 to +52
<td
className={twMerge(
props.tableselecting?.breakOut?.breakoutVisibility ? "table-cell" : "hidden"
)}
colSpan={table.getVisibleLeafColumns().length}
>
<TableBreakout
keys={props.tableselecting?.breakOut?.keys ?? {} as Record<string, string>}
row={table.getSelectedRowModel().flatRows[0]}
/>
</td>
</tr>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this table section do exactly?

@maany maany closed this Nov 13, 2024
@maany maany deleted the esilvaju/issue372 branch December 19, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants