Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 425. Multiple account sign in and account switching #451

Merged
merged 15 commits into from
Aug 13, 2024

Conversation

MytsV
Copy link
Contributor

@MytsV MytsV commented Aug 8, 2024

Partial implementation for #425

  • Improve the structure of the account dropdown
  • Add a possibility to sign in multiple times
  • Handle switching the active user in the session
  • Seemingly fix the logout redirection issue (Logout: Redirects #422) from the viewpoint of a user

Needs integration with the multiple account modal for completion

@MytsV MytsV force-pushed the feature-425-account_switching branch from 2cbc34a to f1c238f Compare August 8, 2024 15:40
@MytsV
Copy link
Contributor Author

MytsV commented Aug 8, 2024

TODOs:

  • investigate the issue with logout/switch not working until the page is refreshed
  • show an error if the user tries to log into an already authenticated account
  • don't display the current account in the multiple account modal

@MytsV
Copy link
Contributor Author

MytsV commented Aug 9, 2024

  • logout from all button

@maany maany added this to the 35.1.0 milestone Aug 9, 2024
@MytsV
Copy link
Contributor Author

MytsV commented Aug 9, 2024

The error in the build is caused by an intentional choice of using the <a> element instead of <Link>, as it prevents a bug caused by Next.js route caching.
The user couldn't log out in some unpredictable scenarios as the router just performed the redirect without the logic underneath it

@MytsV
Copy link
Contributor Author

MytsV commented Aug 9, 2024

#425 finished fully

@MytsV
Copy link
Contributor Author

MytsV commented Aug 9, 2024

This fixes #422 as well

@MytsV MytsV force-pushed the feature-425-account_switching branch from fad0b86 to fe9b766 Compare August 9, 2024 13:47
@maany maany merged commit 458d903 into rucio:master Aug 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SiteHeader: Test if multiple accounts are visible correctly and switching accounts works
2 participants