Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect feature flag documented on join! macro #2804

Closed
wants to merge 1 commit into from
Closed

Fix incorrect feature flag documented on join! macro #2804

wants to merge 1 commit into from

Conversation

RAnders00
Copy link

The join! and try_join! macros are behind the async-await-macro feature flag, not async-await.

The join! and try_join! macros are behind the async-await-macro feature flag, not async-await.
@taiki-e
Copy link
Member

taiki-e commented Nov 25, 2023

Hmm. The current one is correct for the futures documentation, but indeed incorrect for the futures-util documentation.

async-await = []
async-await-macro = ["async-await", "futures-macro"]

async-await = ["futures-util/async-await", "futures-util/async-await-macro"]

0.4 should fix the difference here (#2308 (comment), #2295), but it is not clear how we should handle this in 0.3.

@taiki-e
Copy link
Member

taiki-e commented Feb 26, 2024

Closing -- as said above, 0.3 requires a more complex fix and 0.4 does not need to do anything. In any case, this PR will not work as a corrective to any of these as it is.

Thanks anyway for the PR!

@taiki-e taiki-e closed this Feb 26, 2024
@RAnders00 RAnders00 deleted the patch-1 branch February 28, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants