Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump general MSRV to 1.63 #2907

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Bump general MSRV to 1.63 #2907

merged 1 commit into from
Jan 12, 2025

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jan 7, 2025 •
edited
Loading

as discussed in: #2905 (comment)

This should avoid MSRV issues that show up in CI testing with transitive libc dependency & possibly other dependencies in the future.

CI TESTING TODO(S):

OTHER TODO(S):

@brodycj brodycj changed the title Bump MSRV of main crates to 1.63 Bump general MSRV to 1.63 Jan 7, 2025
This was referenced Jan 7, 2025
Open
Draft
@brodycj brodycj marked this pull request as ready for review January 7, 2025 02:21
@brodycj brodycj mentioned this pull request Jan 7, 2025
Closed
3 tasks
@brodycj brodycj marked this pull request as draft January 7, 2025 02:58
brodycj added a commit to brodycj/futures-rs that referenced this pull request Jan 7, 2025
@brodycj
XXX TBD try util-msrv with 1.63 as well as 1.56 - XXX TODO REVERT in …
e997d35 
…favor of merging other PR rust-lang#2907
@brodycj brodycj marked this pull request as ready for review January 7, 2025 03:59
@brodycj brodycj mentioned this pull request Jan 7, 2025
Draft
2 tasks
taiki-e
taiki-e approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 036957b into rust-lang:master Jan 12, 2025
23 of 24 checks passed
@taiki-e taiki-e mentioned this pull request Jan 12, 2025
Merged
@brodycj brodycj deleted the general-msrv-1.63 branch January 12, 2025 17:53
@brodycj
Copy link
Contributor Author

brodycj commented Jan 12, 2025

Thanks to you for handling the updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brodycj @taiki-e