Fix potential panic due to huge layout #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user provides a layout with a big enough size, the allocator might panic on an unwrap instead of returning an error. The reason is that, even though the layout size is properly rounded to a power of two, Layout::from_size_align() will fail if the size overflows isize when rounded to the layout alignment. Fix this by handling the error instead of unwrapping it. Keep an unwrap in the HoleList::deallocate() as the validity of the layout must be guaranteed by the caller since it is an unsafe function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user provides a layout with a big enough size, the allocator might panic on an unwrap instead of returning an error. The reason is that, even though the layout size is properly rounded to a power of two,
Layout::from_size_align()will fail if the size overflows isize when rounded to the layout alignment.Fix this by handling the error instead of unwrapping it.
Keep an unwrap in the
HoleList::deallocate()as the validity of the layout must be guaranteed by the caller since it is an unsafe function.